fix(location) : 修复多次render导致tab栏下划线动画不流畅的问题#260
Closed
lovelyJason wants to merge 2 commits intoreact-component:masterfrom
Closed
fix(location) : 修复多次render导致tab栏下划线动画不流畅的问题#260lovelyJason wants to merge 2 commits intoreact-component:masterfrom
lovelyJason wants to merge 2 commits intoreact-component:masterfrom
Conversation
if (activeTab ) {
...
componentDidUpdate() {
// resolve the probleme that when our component render many times ,inkTabBarNode's animation is not smoothly.
componentDidUpdate(this, false, prevProps);
}
======>
if (activeTab && (!prevProps || activeKey !== prevProps.activeKey)) {
...
componentDidUpdate() {
componentDidUpdate(this);
}
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/tabs/2zj7bhkdt |
if (activeTab ) {
}
...
componentDidUpdate() {
componentDidUpdate(this);
}
======>
// 多添加个判断条件,重复的activeKey不设置动画
if (activeTab && (!prevProps || activeKey !== prevProps.activeKey)) {
}
...
componentDidUpdate(prevProps) {
// resolve the probleme that when our component render many times ,inkTabBarNode's animation is not smoothly.
componentDidUpdate(this, false, prevProps);
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if (activeTab ) {
}
...
componentDidUpdate() {
componentDidUpdate(this);
}
======>
// 多添加个判断条件,重复的activeKey不设置动画
if (activeTab && (!prevProps || activeKey !== prevProps.activeKey)) {
}
...
componentDidUpdate(prevProps) {
// resolve the probleme that when our component render many times ,inkTabBarNode's animation is not smoothly.
componentDidUpdate(this, false, prevProps);
}